Hitless handshake #3735
Open
Hitless handshake #3735
+589
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Kolevska <[email protected]> Cleanup Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
elena-kolevska
commented
Aug 12, 2025
Signed-off-by: Elena Kolevska <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR implements handshake functionality for hitless upgrades and updates the server maintenance message format to include sequence IDs for better event tracking.
- Adds endpoint type detection and CLIENT MAINT_NOTIFICATIONS command for proper handshake setup
- Updates maintenance event message parsing to handle new format with sequence IDs
- Changes default behavior to enable maintenance events by default
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
redis/maintenance_events.py |
Adds EndpointType class and endpoint detection logic, enables maintenance events by default |
redis/connection.py |
Implements handshake via CLIENT MAINT_NOTIFICATIONS command during connection setup |
redis/_parsers/base.py |
Updates message parsing to handle new format with sequence IDs and adds error handling |
tests/test_maintenance_events.py |
Adds comprehensive tests for endpoint type detection and configuration validation |
tests/test_maintenance_events_handling.py |
Updates mock responses to match new message format with sequence IDs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| return False | ||
|
|
||
|
|
||
| def _get_resolved_ip_from_connection( |
There was a problem hiding this comment.
I think it would be better to expose this function on the connection object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change